Add error message for invalid float input

A few people encountered these. Looks like a few other filters don’t
clip their limited range output properly.
This commit is contained in:
kageru 2020-03-25 11:07:21 +01:00
parent 3307943585
commit 70e782612d
Signed by: kageru
GPG Key ID: 8282A2BEA4ADA3D2
2 changed files with 17 additions and 1 deletions

View File

@ -1,6 +1,6 @@
[package]
name = "adaptivegrain-rs"
version = "0.2.0"
version = "0.2.1"
authors = ["kageru"]
edition = "2018"

View File

@ -174,9 +174,25 @@ impl<'core> Filter<'core> for Mask<'core> {
}
}
SampleType::Float => {
if let Err(e) = verify_input_range(&src_frame.props()) {
bail!(e);
}
filter_for_float(&mut frame, src_frame, average, self.luma_scaling);
}
}
Ok(frame.into())
}
}
fn verify_input_range<'a>(props: &vapoursynth::map::MapRef<'a, 'a>) -> Result<(), String> {
let max = props.get::<f64>("PlaneStatsMax").unwrap_or(1.0);
let min = props.get::<f64>("PlaneStatsMin").unwrap_or(0.0);
if min < 0.0 || max > 1.0 {
return Err(format!(
"{}: found invalid input. Some pixels are outside of the valid range.
You probably used a filter that operates on limited range without clipping properly, e.g. edgefixer, before converting to float.
This can be fixed by clipping all pixels to (0, 1) with Expr or converting to an integer format.", PLUGIN_NAME
));
}
Ok(())
}